[Ocfs2-devel] Heart beat source code review and test, founding it may be not correct. Is the changes OK, requesting reviews and advices.

[Sunil Mushran]

What's the reasoning behind this patch?

On Jul 31, 2013, at 3:51 AM, Guozhonghua <guozhonghua at h3c.com> wrote:

> Hi,
>  
> I find some code may be not correct as reviewing the heart beat code and test that.
> The heart beat writing onto disk.
> I have another question that why not encapsulate the o2hb_wait_on_io into the function o2hb_issue_node_write, just as the function o2hb_read_slots.
> I don’t know whether the changes is correct.
> Requesting reviews of the changes? Thanks.
>  
>  
> diff -p -C 6 cluster-old/heartbeat.c cluster-new/heartbeat.c
> *** cluster-old/heartbeat.c    2013-07-31 18:18:35.625069131 +0800
> --- cluster-new/heartbeat.c    2013-07-31 18:18:35.613069052 +0800
> *************** static int o2hb_do_disk_heartbeat(struct
> *** 1029,1046 ****
>       ret = o2hb_issue_node_write(reg, &write_wc);
>       if (ret < 0) {
>               mlog_errno(ret);
>               goto bail;
>       }
>  
> -      i = -1;
> -      while((i = find_next_bit(configured_nodes,
> -                               O2NM_MAX_NODES, i + 1)) < O2NM_MAX_NODES) {
> -              membership_change |= o2hb_check_slot(reg, &reg->hr_slots[i]);
> -      }
> -
>       /*
>        * We have to be sure we've advertised ourselves on disk
>        * before we can go to steady state.  This ensures that
>        * people we find in our steady state have seen us.
>        */
>       o2hb_wait_on_io(reg, &write_wc);
> --- 1029,1040 ----
> *************** static int o2hb_do_disk_heartbeat(struct
> *** 1058,1069 ****
> --- 1052,1069 ----
>       if (own_slot_ok) {
>               o2hb_set_quorum_device(reg);
>               o2hb_arm_write_timeout(reg);
>       }
>  
>   bail:
> +     i = -1;
> +     while((i = find_next_bit(configured_nodes,
> +                              O2NM_MAX_NODES, i + 1)) < O2NM_MAX_NODES) {
> +             membership_change |= o2hb_check_slot(reg, &reg->hr_slots[i]);
> +     }
> +        
>       /* let the person who launched us know when things are steady */
>       if (atomic_read(&reg->hr_steady_iterations) != 0) {
>               if (!ret && own_slot_ok && !membership_change) {
>                       if (atomic_dec_and_test(&reg->hr_steady_iterations))
>                               wake_up(&o2hb_steady_queue);
>               }
>  
>  
> -------------------------------------------------------------------------------------------------------------------------------------
> 本邮件及其附件含有杭州华三通信技术有限公司的保密信息，仅限于发送给上面地址中列出
> 的个人或群组。禁止任何其他人以任何形式使用（包括但不限于全部或部分地泄露、复制、
> 或散发）本邮件中的信息。如果您错收了本邮件，请您立即电话或邮件通知发件人并删除本
> 邮件！
> This e-mail and its attachments contain confidential information from H3C, which is 
> intended only for the person or entity whose address is listed above. Any use of the 
> information contained herein in any way (including, but not limited to, total or partial 
> disclosure, reproduction, or dissemination) by persons other than the intended 
> recipient(s) is prohibited. If you receive this e-mail in error, please notify the sender 
> by phone or email immediately and delete it!
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> https://oss.oracle.com/mailman/listinfo/ocfs2-devel
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://oss.oracle.com/pipermail/ocfs2-devel/attachments/20130731/a3dd3470/attachment.html