[Ocfs2-devel] [PATCH V3] ocfs2: xattr: fix inlined xattr reflink

Andrew Morton akpm at linux-foundation.org
Tue Jul 2 12:17:53 PDT 2013


On Tue, 2 Jul 2013 08:40:42 -0700 Joel Becker <jlbec at evilplan.org> wrote:

> On Tue, Jul 02, 2013 at 11:12:33AM +0800, Junxiao Bi wrote:
> > 
> > 4244         mutex_lock_nested(&new_inode->i_mutex, I_MUTEX_CHILD);
> > 4245         ret = ocfs2_inode_lock_nested(new_inode, &new_bh, 1,
> > 4246                                       OI_LS_REFLINK_TARGET);
> 
> 	The i_mutex protects the VFS inode.  The ocfs2_inode_lock
> protects against other nodes in the cluster.  new_oi->ip_lock protects
> the ocfs2_inode_info specific stuff.
> 	Reading a bit out of new_oi->ip_dyn_features is probably safe;
> we are protected from inline data being converted to extents.  So I
> suppose this isn't terribly different than xattr_ibody_init().

Was that a soggy ack?  :)




More information about the Ocfs2-devel mailing list