[Ocfs2-devel] [RESENT PATCH 4/4] ocfs2: adjust switch_case syntax at o2net_state_change()

[Andrew Morton]

On Mon, 1 Jul 2013 16:04:21 -0700 Joel Becker <jlbec at evilplan.org> wrote:

> On Sat, Jun 29, 2013 at 12:01:19PM +0800, Jeff Liu wrote:
> > From: Jie Liu <jeff.liu at oracle.com>
> > 
> > Adjust switch..case syntax at o2net_state_change to meet
> > the kernel coding standard.
> > 
> > s/printk/pr_info/.
> > 
> > Signed-off-by: Jie Liu <jeff.liu at oracle.com>
> 
> 	Switching to pr_info() hasn't been discussed as part of the
> project.  Let's have that conversation elsewhere.
> 

I reverted that bit.

It was wrong anyway:

> > +		pr_info(KERN_INFO "o2net: Connection to " SC_NODEF_FMT
> > +			" shutdown, state %d\n",
> > +			SC_NODEF_ARGS(sc), sk->sk_state);

Should remove the "KERN_INFO " now.


Switching to pr_foo is a good idea, I find.  A nice thing about it is
that it reduces the length of the lines quite a lot, and printk
statements are often quite long lines.  The net effect is that a *lot*
of nasty make-it-fit-in-80-columns tricks just vanish.