[Ocfs2-devel] [PATCH] ocfs2: fix ocfs2_init_security_and_acl() to initialize acl correctly

[Andrew Morton]

On Sat, 23 Feb 2013 10:12:10 +0800 Jeff Liu <jeff.liu at oracle.com> wrote:

> Hi Andrew,
> 
> On 02/23/2013 05:21 AM, Andrew Morton wrote:
> > On Fri, 22 Feb 2013 19:15:46 +0800
> > Jeff Liu <jeff.liu at oracle.com> wrote:
> > 
> >> We need to re-initialize the security if it isn't preserved for ocfs2_reflink().
> >> however, the code logic is broken at ocfs2_init_security_and_acl() although
> >> ocfs2_init_security_get() succeed, as a result, ocfs2_acl_init() does not involked.
> > 
> > When writing a changelog, please describe the end-user-visible effects
> > of the bug, so that others can more easily decide which kernel
> > version(s) should be fixed, and so that downstream kernel maintainers
> > can more easily work out whether this patch will fix a problem which
> > they or their customers are observing.
> Thanks for your teaching, I'll take care of it next time.
> 

Well OK, but please provide this info for this particular patch!  I
still don't know if we should backport it into -stable kernels.