[Ocfs2-devel] [PATCH 06/21] ocfs2: drop vmtruncate
Joel Becker
jlbec at evilplan.org
Wed Oct 24 17:18:23 PDT 2012
On Tue, Oct 23, 2012 at 02:48:38PM +0200, Marco Stornelli wrote:
> 2012/10/23 Joel Becker <jlbec at evilplan.org>:
> > On Tue, Oct 23, 2012 at 10:58:42AM +0200, Marco Stornelli wrote:
> >> 2012/10/23 Joel Becker <jlbec at evilplan.org>:
> >> > On Sat, Oct 20, 2012 at 02:19:00PM +0200, Marco Stornelli wrote:
> >> >> Removed vmtruncate
> >> >>
> >> >> Signed-off-by: Marco Stornelli <marco.stornelli at gmail.com>
> >> >
> >> > Acked-by: Joel Becker <jlbec at evilplan.org>
> >> >
> >> > Do you want me to pull this, or are you going to send it with your set?
> >> >
> >> > Joel
> >> >
> >>
> >> I'd prefer to push all via Al's tree since there is a VFS change.
> >
> > SGTM. Thanks!
> >
> > Joel
> >
>
> I've got a doubt and I ask to ocfs2 expert :) It seems i_size_write()
> and truncate_inode_pages() and so on, they are already called in each
> path of setattr for a size change, so maybe we can remove
> truncate_setsize() and simply to remove the vmtuncate code, can you
> give me your opinion?
Actually, I have to revisit this, because Chrisoph points out
your adjusting i_size outside of a transaction.
Joel
> Thanks.
>
> Marco
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo at vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
"Practice random acts of kindness and senseless acts of beauty."
Oh, and don't forget where your towel is.
http://www.jlbec.org/
jlbec at evilplan.org
More information about the Ocfs2-devel
mailing list