[Ocfs2-devel] fix mlog_errno in ocfs2_global_read_info

Tiger Yang tiger.yang at oracle.com
Mon Jun 25 01:00:19 PDT 2012


Hi, All,

When mount ocfs2 with option usrquota and grpquota, we will see below 
message:

(mount.ocfs2,9434,1):ocfs2_global_read_info:403 ERROR: status = 24
(mount.ocfs2,9434,3):ocfs2_global_read_info:403 ERROR: status = 24

But actually this should not be a error.

In ocfs2_global_read_info, if  read_quota() succeed, status is the size 
of the struct ocfs2_global_disk_dqinfo, only when it is not equal to the 
correct size, it will be a error. So this positive value should be 
return and should not log it as a error.

I made a patch to fix this, and in the patch I removed the redundant 
mlog_errno also.

Thanks for review

Tiger



More information about the Ocfs2-devel mailing list