[Ocfs2-devel] [PATCH] ocfs2: for SEEK_DATA/SEEK_HOLE, return internal error unchanged if ocfs2_get_clusters_nocache() or ocfs2_inode_lock() call failed.
Joel Becker
jlbec at evilplan.org
Wed Jul 4 00:32:23 PDT 2012
On Thu, Feb 09, 2012 at 02:42:22PM +0800, Jeff Liu wrote:
> Hello,
>
> Since ENXIO only means "offset beyond EOF" for SEEK_DATA/SEEK_HOLE,
> Hence we should return the internal error unchanged if ocfs2_inode_lock() or
> ocfs2_get_clusters_nocache() call failed rather than ENXIO.
> Otherwise, it will confuse the user applications when they trying to understand the root cause.
>
> Thanks Dave for pointing this out.
>
> Thanks,
> -Jeff
>
>
> Cc: Dave Chinner <david at fromorbit.com>
> Signed-off-by: Jie Liu <jeff.liu at oracle.com>
This patch is now (finally) part of the 'fixes' branch of ocfs2.git.
Joel
>
> ---
> fs/ocfs2/extent_map.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/fs/ocfs2/extent_map.c b/fs/ocfs2/extent_map.c
> index 2f5b92e..70b5863 100644
> --- a/fs/ocfs2/extent_map.c
> +++ b/fs/ocfs2/extent_map.c
> @@ -923,8 +923,6 @@ out_unlock:
>
> ocfs2_inode_unlock(inode, 0);
> out:
> - if (ret && ret != -ENXIO)
> - ret = -ENXIO;
> return ret;
> }
>
> --
> 1.7.9
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel
--
"Nearly all men can stand adversity, but if you really want to
test a man's character, give him power."
- Abraham Lincoln
http://www.jlbec.org/
jlbec at evilplan.org
More information about the Ocfs2-devel
mailing list