[Ocfs2-devel] [PATCH V2] ocfs2: break useless while loop

Junxiao Bi junxiao.bi at oracle.com
Thu Aug 9 22:54:30 PDT 2012


Hi Joel,

Could you merge this patch?

On 08/10/2012 01:52 PM, Junxiao Bi wrote:
> Signed-off-by: Junxiao Bi <junxiao.bi at oracle.com>
> Acked-by: Sunil Mushran <sunil.mushran at gmail.com>
> ---
>  fs/ocfs2/dlm/dlmmaster.c |    4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/fs/ocfs2/dlm/dlmmaster.c b/fs/ocfs2/dlm/dlmmaster.c
> index 005261c..1fadc39 100644
> --- a/fs/ocfs2/dlm/dlmmaster.c
> +++ b/fs/ocfs2/dlm/dlmmaster.c
> @@ -1888,8 +1888,10 @@ ok:
>  			 * up nodes that this node contacted */
>  			while ((nn = find_next_bit (mle->response_map, O2NM_MAX_NODES,
>  						    nn+1)) < O2NM_MAX_NODES) {
> -				if (nn != dlm->node_num && nn != assert->node_idx)
> +				if (nn != dlm->node_num && nn != assert->node_idx) {
>  					master_request = 1;
> +					break;
> +				}
>  			}
>  		}
>  		mle->master = assert->node_idx;




More information about the Ocfs2-devel mailing list