[Ocfs2-devel] [PATCH] vfs: Correctly set the dir i_mutex lockdep class

[Joel Becker]

On Thu, Nov 10, 2011 at 09:28:49AM -0600, Tyler Hicks wrote:
> On 2011-11-10 15:33:19, Jan Kara wrote:
> > On Thu 10-11-11 00:45:00, Tyler Hicks wrote:
> > > This patch removes the negation from the conditional so that the i_mutex
> > > lockdep class is properly set for directory inodes. Special classes are
> > > preserved and directory inodes with unmodified classes are set with
> > > i_mutex_dir_key.
> >   Duh, you are right. I wonder how come this did not trigger any lockdep
> > messages during my testing with ocfs2 for which I wrote the patch...
> 
> Good question. Adding the ocfs2 maintainers and devel list to cc, as
> this patch is likely to change up their lockdep warnings.

	We don't set special classes for dir->i_mutex.  We set special
classes on our DLM stuff, and we do it for our system files, but not for
regular directories.

Joel


-- 

Life's Little Instruction Book #356

	"Be there when people need you."

			http://www.jlbec.org/
			jlbec at evilplan.org