[Ocfs2-devel] [PATCH 1/1] ocfs2: clean up mount option about atime in ocfs2.txt

[Joel Becker]

On Wed, Mar 02, 2011 at 07:32:09PM +0800, Tiger Yang wrote:
> -	if (osb->s_atime_quantum != OCFS2_DEFAULT_ATIME_QUANTUM)
> +	if (!(mnt->mnt_flags & MNT_NOATIME) && !(mnt->mnt_flags & MNT_RELATIME))
>  		seq_printf(s, ",atime_quantum=%u", osb->s_atime_quantum);

	I can see why you don't print in the case of noatime or
relatime, but you should keep the check for DEFAULT_ATIME_QUANTUM.
There's no point in printing it if it is the default.

Joel

-- 

Life's Little Instruction Book #510

	"Count your blessings."

			http://www.jlbec.org/
			jlbec at evilplan.org