[Ocfs2-devel] [PATCH] remove lockres from purge list when we are getting it for creating lock

Wengang Wang wen.gang.wang at oracle.com
Thu Jun 9 18:21:46 PDT 2011


On 11-06-09 18:10, Sunil Mushran wrote:
> On 06/09/2011 06:01 PM, Wengang Wang wrote:
> >
> >Yes, you are right. There is such a problem that the lockres can be
> >added to purge list after we drop dlm->spinlock. I am not sure if it's the more
> >likely case since there is a 8 seconds delay between the the time the lockres is
> >added to purge list and the time it is purged. I guess in normal case, the create-
> >lock should already finished in the 8 seconds.
> >
> >I considered about the inflight_locks. But I didn't think it well so far.
> >Because simply moving the lockres out from purge list is not good
> >enough, I will take a good think about making use of inflight_locks.
> >
> >>Secondly, we currently manipulate the purgelist in one function only.
> >>__dlm_calc_lockres_usage(). We should stick to that.
> >If we make good use of inflight_locks, I think we can.
> >>BTW, how are you testing this?
> >I tested with the steps which can cause the original problem to prove it
> >works.(but without UT).
> >Also I made a regression test with the existing ocfs2-test suites(the
> >multiple-xxx with reducing interations).
> 
> What's UT?

unit test :)
> 
> I am looking for is a testcase that reliably reproduces the problem.
> Not necessarily that can be checked in. But something that triggers
> the issue.

sent via an another email.

thanks,
wengang.



More information about the Ocfs2-devel mailing list