[Ocfs2-devel] [PATCH 2/3] ocfs2: let ocfs2_dir_foreach return the error turned by filldir

[Wengang Wang]

On 11-07-08 10:07, Wengang Wang wrote:
> On 11-07-07 13:09, Sunil Mushran wrote:
> > On 07/05/2011 09:40 PM, Wengang Wang wrote:
> > >Let ocfs2_dir_foreach return the error turned by filldir.
> > >
> > >Signed-off-by: Wengang Wang<wen.gang.wang at oracle.com>
> > >---
> > >  fs/ocfs2/dir.c |    2 ++
> > >  1 files changed, 2 insertions(+), 0 deletions(-)
> > >
> > >diff --git a/fs/ocfs2/dir.c b/fs/ocfs2/dir.c
> > >index 8582e3f..6d7560a 100644
> > >--- a/fs/ocfs2/dir.c
> > >+++ b/fs/ocfs2/dir.c
> > >@@ -2005,6 +2005,8 @@ int ocfs2_dir_foreach(struct inode *inode, loff_t *f_pos, void *priv,
> > >
> > >  	if (ret>  0)
> > >  		ret = -EIO;
> > >+	if (!ret)
> > >+		ret = filldir_err;
> > >
> > >  	return 0;

I meant "return ret" here.

> > >  }
> > 
> > That's not enough. Shouldn't it be "return ret" too.
> 
> If neccesary, We can return both ret and filldir_err.
> > 
> > Have you triggered this error manually? I have never seen reports of it
> > before.
> 
> No error here. This change is only needed for the following patch:
> [PATCH 3/3] ocfs2: drop and retake orphan_dir.i_mutex in ocfs2_recover_orphans.
> 
> thanks,
> wengang.