[Ocfs2-devel] [PATCH 01/14] Ocfs2/refcounttree: Fix a bug for refcounttree to writeback clusters in a right number.

Tristan Ye tristan.ye at oracle.com
Thu Jan 27 17:43:24 PST 2011


Mark Fasheh wrote:
> On Fri, Jan 21, 2011 at 06:20:18PM +0800, Tristan Ye wrote:
>> Current refcounttree codes actually didn't writeback the new pages out in
>> write-back mode, due to a bug of always passing a ZERO number of clusters
>> to 'ocfs2_cow_sync_writeback', the patch tries to pass a proper one in.
>>
>> Signed-off-by: Tristan Ye <tristan.ye at oracle.com>
>
> Seems to look reasonable to me, though Joel or Tao might want to give their
> own quick SOB too.

Mark,

    Thanks for your quick review;-)

>
> Joel: I think we want this particular patch to go upstream sooner than
> later, yes?

Yep, it's more like a stand-alone fix for reflink than one part of 
defragmentation patches.

It thus will be better to have this in next 'fixes' commit.


Tristan.

>
> Signed-off-by: Mark Fasheh <mfasheh at suse.com>
> 	--Mark
>
> --
> Mark Fasheh




More information about the Ocfs2-devel mailing list