[Ocfs2-devel] [Patch] Kill off warning: ‘inline’ is not at beginning of declaration

Jesper Juhl jj at chaosbits.net
Wed Jan 19 07:45:12 PST 2011


On Wed, 19 Jan 2011, Jiri Kosina wrote:

> On Mon, 17 Jan 2011, Jesper Juhl wrote:
> 
> > Fix a bunch of 
> > 	warning: ‘inline’ is not at beginning of declaration
> > messages when building a 'make allyesconfig' kernel with -Wextra.
> > 
> > These warnings are trivial to kill, yet rather annoying when building with 
> > -Wextra.
> > The more we can cut down on pointless crap like this the better (IMHO).
> > 
> > A previous patch to do this for a 'allnoconfig' build has already been 
> > merged. This just takes the cleanup a little further.
> > 
> > Signed-off-by: Jesper Juhl <jj at chaosbits.net>
> > ---
> >  arch/x86/oprofile/op_model_p4.c |    2 +-
> >  drivers/bluetooth/btusb.c       |    4 ++--
> >  drivers/cpuidle/sysfs.c         |    2 +-
> >  drivers/edac/i7300_edac.c       |    2 +-
> >  fs/ocfs2/dir.c                  |    2 +-
> >  kernel/trace/ring_buffer.c      |    2 +-
> >  net/ipv6/inet6_hashtables.c     |    2 +-
> >  net/mac80211/tx.c               |    2 +-
> >  sound/pci/au88x0/au88x0.h       |    4 ++--
> >  sound/pci/au88x0/au88x0_core.c  |    4 ++--
> >  10 files changed, 13 insertions(+), 13 deletions(-)
> > 
>
> Wow, what a huge CC list for such a simple change. Jesper, I think you 
> should re-consider this next time. I bet you used get_maintainer script, 
> didn't you? :)
> 

Yes, I did. I wanted to be sure that everyone whoes code I was modifying 
got the mail. I guess I should have broken it up into smaller pieces and 
submitted them as a series instead.


> I have applied it to my tree now. If anyone has objections/has already 
> applied part of the patch to subsystem tree, please let me know.
> 

Thank you.

-- 
Jesper Juhl <jj at chaosbits.net>            http://www.chaosbits.net/
Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html
Plain text mails only, please.


More information about the Ocfs2-devel mailing list