[Ocfs2-devel] [PATCH] Treat writes as new when holes span across page boundaries

Mark Fasheh mfasheh at suse.com
Thu Feb 24 10:16:20 PST 2011


On Thu, Feb 24, 2011 at 10:32:44AM -0600, Goldwyn Rodrigues wrote:
> Hi Joel,
> 
> On Wed, Feb 23, 2011 at 3:44 PM, Joel Becker <jlbec at evilplan.org> wrote:
> >
> >        I would love to see you modify tailtest to expose this bug.  You
> > should be able to do it with one set of writes (your write(4k),
> > write(32b), write(4K at someplace past 4K+32b)) test).  It will be a lot
> > easier to debug if it is a simple script rather than a bunch of C
> > writes.
> >
> 
> I have posted the patch for ocfs2-test on the test mailing list.
> 
> While coding the test, I discovered that the problem does not occur
> for sparse,inline-data. I thought it might be because it is the first
> test in the series so I changed the order and confirmed that the test
> does not fail for sparse,inline-data. Any ideas?

Inline gets a bit of special handling in the write cases, especially when
you cross the boundary into extents. My guess is that the zeroing in that
case is somehow already correct? Possibly that's just by dumb luck.
	--Mark

--
Mark Fasheh



More information about the Ocfs2-devel mailing list