[Ocfs2-devel] [PATCH] Treat writes as new when holes span across page boundaries

[Joel Becker]

On Wed, Feb 23, 2011 at 03:00:58PM -0600, Goldwyn Rodrigues wrote:
> On Wed, Feb 23, 2011 at 1:28 PM, Joel Becker <jlbec at evilplan.org> wrote:
> > On Wed, Feb 23, 2011 at 11:13:39AM -0800, Joel Becker wrote:
> >> The calling code should have made sure we are correctly passing
> >> should_zero to all non-target pages.  Having new overridden for them is
> >> wrong.  So maybe we move your check inside the target_page if.  It only
> >> really matters for the target page.
> >
> >        Actually, I have a question: what is the clustersize of your
> > test?  Because if the filesystem is 4k/4k, the write at 4096 of 32 bytes
> > should allocate a new cluster.  'new' should already be set, and your
> > check irrelevant.
> 
> It is 16K and does not happen for clustersize==pagesize/blocksize.
> Don't have a machine with a bigger pagesize handy.

	That's what I expected.

Joel

-- 

"What no boss of a programmer can ever understand is that a programmer
 is working when he's staring out of the window"
	- With apologies to Burton Rascoe

			http://www.jlbec.org/
			jlbec at evilplan.org