[Ocfs2-devel] [PATCH 2/3] Ocfs2: Add a new code 'OCFS2_INFO_FREEINODE' for o2info ioctl.

[Joel Becker]

On Tue, Feb 22, 2011 at 12:59:51PM +0800, Tristan Ye wrote:
> +	oifi = kzalloc(sizeof(struct ocfs2_info_freeinode), GFP_NOFS);

	Why NOFS?  Are we under any filesystem locks?  I'm pretty sure
this is the first thing you do for this operation, so why wouldn't
GFP_KERNEL work?

Joel

-- 

"I always thought the hardest questions were those I could not answer.
 Now I know they are the ones I can never ask."
			- Charlie Watkins

			http://www.jlbec.org/
			jlbec at evilplan.org