[Ocfs2-devel] [PATCH v2] ocfs2: Move 'wanted' into parens of ocfs2_resmap_resv_bits.
Joel Becker
Joel.Becker at ORACLE.COM
Thu Sep 23 14:23:24 PDT 2010
On Sun, Sep 19, 2010 at 01:42:28PM +0800, Tao Ma wrote:
> The first time I read the function ocfs2_resmap_resv_bits, I consider
> about what 'wanted' will be used and consider about the comments.
> Then I find it is only used if the reservation is empty. ;)
>
> So we'd better move it to the parens so that it make the code more
> readable, what's more, ocfs2_resmap_resv_bits is used so frequently
> and we should save some cpus. The corresponding BUG_ON is also moved
> into parens since it is only meaningful after we reinit the resv.
>
> Acked-by: Mark Fasheh <mfasheh at suse.com>
> Signed-off-by: Tao Ma <tao.ma at oracle.com>
This patch is now in the 'fixes' branch of ocfs2.git.
Joel
--
"Also, all of life's big problems include the words 'indictment' or
'inoperable.' Everything else is small stuff."
- Alton Brown
Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
More information about the Ocfs2-devel
mailing list