[Ocfs2-devel] [PATCH 1/1] Ocfs2: Add new OCFS2_IOC_INFO ioctl for ocfs2 v7.

[Joel Becker]

On Fri, May 21, 2010 at 05:07:11PM +0800, tristan wrote:
> That's definitely a MUST!! since I caught another bug running 32bits 
> application on 64bits kernel, the problem is I didn't make the 
> 'ocfs2_info' structure 64bits aligned, which caused a failure to 
> recognize this ioctl from a 32bits application. Following is all that 
> I'm going to change against this issue:
> 
> --------------------------------------------------------------------------
> struct ocfs2_info {
> __u64 oi_requests; /* Array of __u64 pointers to requests */
> - __u32 oi_count; /* Number of requests in info_requests */
> + __u64 oi_count; /* Number of requests in info_requests */
> };

	Don't turn these values into 64bit ones.  Instead, pad the
structure:

struct ocfs2_info {
	__u64 oi_requests;
	__u32 oi_count;
	__u32 oi_pad;
};

That way you can change the structure later to use the pad field without
breaking old code.

Joel

-- 

"Any man who is under 30, and is not a liberal, has not heart;
 and any man who is over 30, and is not a conservative, has no brains."
         - Sir Winston Churchill 

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127