[Ocfs2-devel] [PATCH] ocfs2/xattr: Reset xattr value size in cleanup_truncate.

Joel Becker Joel.Becker at oracle.com
Fri May 7 14:09:33 PDT 2010


On Fri, May 07, 2010 at 02:17:34PM +0800, Tao Ma wrote:
> So this patch try to resolve it by adding the original_value_size to
> ocfs2_xa_cleanup_value_truncate and let it handle it. So xe_value_size
> will only be reset in case we want to reserve the xe entry. There is
> also a side effect that we can remove the fat comment before we set
> the xe_value_size in ocfs2_xa_prepare_entry.

	Still NAK.  There's no need for cleanup_value_truncate() to know
about this.

Joel

-- 

"When arrows don't penetrate, see...
 Cupid grabs the pistol."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-devel mailing list