[Ocfs2-devel] [PATCH 13/15] ocfs2: ocfs2_group_bitmap_size has to handle old volume.

[Tao Ma]

Hi Joel,

Joel Becker wrote:
> On Thu, Apr 01, 2010 at 10:59:10AM +0800, Tao Ma wrote:
>> ocfs2_group_bitmap_size has to handle the case when the
>> volume don't have discontiguous block group support.
> 
> 	NAK.  We specify 256 in all cases.  This doesn't hurt old code
> because we've never used more bits.  Even though our old bg_size values
> were much larger, we never used that space because bg_bits was set to
> the smaller value.
No, it hurts.
So with an old ocfs2-tools and a new kernel, the new kernel will set it 
to 256 while the old ocfs2-tools refused to work by checking bg_size(see
chainalloc_process_group in libocfs2).

Regards,
Tao