[Ocfs2-devel] [PATCH] ocfs2: one more warning fix in ocfs2_file_aio_write()

[Coly Li]

On 2010年03月26日 04:45, Joel Becker Wrote:
> On Fri, Mar 26, 2010 at 04:21:39AM +0800, Coly Li wrote:
>> This patch fixes another compiling warning in ocfs2_file_aio_write() like this,
>>     fs/ocfs2/file.c: In function ‘ocfs2_file_aio_write’:
>>     fs/ocfs2/file.c:2026: warning: suggest parentheses around ‘&&’ within ‘||’
>>
>> Signed-off-by: Coly Li <coly.li at suse.de>
>> ---
>>  fs/ocfs2/file.c |    4 ++--
>>  1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
>> index 17947dc..c4638fd 100644
>> --- a/fs/ocfs2/file.c
>> +++ b/fs/ocfs2/file.c
>> @@ -2021,8 +2021,8 @@ out_dio:
>>  		if (ret < 0)
>>  			written = ret;
>>
>> -		if (!ret && (old_size != i_size_read(inode) ||
>> -		    old_clusters != OCFS2_I(inode)->ip_clusters ||
>> +		if ((!ret) && ((old_size != i_size_read(inode)) ||
> 
> 	You don't need to wrap the !ret.  It's unary.
> 

Just posted another update, and Cc to you.
Thanks for the review :-)
-- 
Coly Li
SuSE Labs