[Ocfs2-devel] [PATCH 1/1] Ocfs2: Teach truncating and punching-hole codes to handle fastsymlink.

[Joel Becker]

On Wed, Mar 24, 2010 at 10:51:24AM +0800, tristan wrote:
> > 	It's not OK to be there.  The truncate system call will error if
> > it is not a regular file.  Same with OCFS2_IOC_UNRESVP.  Thus no symlink
> > can get there.  ocfs2_truncate_for_delete() checks i_clusters before
> > calling the real truncate code.  Thus it avoids fast symlinks and inline
> > data.
> 
> Joel,
> 
> I agreed with your point on the fact that truncating for fast symlink 
> may be meaningless, since sys_truncate() will block all none-regular 
> files. while it does make sense for inline data, see 
> ocfs2_truncate_inline(), which was used to deal with inline file 
> separately. that's the way we're treating inline file when doing 
> truncating, how did you say we avoid this? that makes me confused.

	For inline data, we shortcut into ocfs2_truncate_inline() and
never go into the meaty truncate code.  That's all I meant.

Joel

-- 

"Reality is merely an illusion, albeit a very persistent one."
        - Albert Einstien

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127