[Ocfs2-devel] [PATCH 1/1] Ocfs2: Teach truncating and punching-hole codes to handle fastsymlink.

[tristan]

Joel Becker wrote:
> On Wed, Mar 24, 2010 at 09:10:13AM +0800, tristan wrote:
>> Joel Becker wrote:
>>> On Tue, Mar 23, 2010 at 04:04:44PM +0800, Tristan Ye wrote:
>>>> Fast symlink can be treated the same way as inline file for truncating
>>>> and hole punching, since the mechanism is quite simliar per se.
>>>>
>>>> Signed-off-by: Tristan Ye <tristan.ye at oracle.com>
>>> 	The patch looks good, with perhaps a bit over-zealous
>>> parentheses ;-)  Is this fixing a bug someone has hit?
>> Not exactly,
>>
>> Sunil reported such a bug from userspace in libocfs2, I suddenly 
>> realised that we could also do the same in fs.
>
> 	The difference is that we never call the truncate code for fast
> symlinks or inline data in the kernel.  We do in libocfs2.

Really?

Truncating for inline data is common I guess, for symlink, we may lack 
of method to truncate it from userspace via ftruncate(2).

But it's ok to be there, right?

Tristan.

>
> Joel
>