[Ocfs2-devel] [PATCH 1/4] ocfs2: Add struct file to ocfs2_refcount_cow.

Tao Ma tao.ma at oracle.com
Wed Jun 30 17:17:37 PDT 2010


Joel Becker wrote:
> On Wed, Jun 30, 2010 at 11:11:47AM +0800, Tao Ma wrote:
>   
>> oh, sorry joel. There does exist one place that we don't have filp.
>> It is in ocfs2_orphan_for_truncate, we have to CoW the cluster
>> containing i_size and pass NULL as filp.
>>     
>
> 	Maybe ocfs2_cow_file_pos() needs both, but write_begin_nolock
> and page_mkwrite do not.
>   
yes, so what do you mean? I am puzzled, sorry.
You mean we export 2 different functions from refcountree.c.
One is ocfs2_refcount_cow_file(struct file *,...)
and another is ocfs2_refcount_cow_inode(struct inode *,...)?


Regards,
Tao



More information about the Ocfs2-devel mailing list