[Ocfs2-devel] [PATCH] ocfs2/dlm: check dlm_state under spinlock

Wengang Wang wen.gang.wang at oracle.com
Thu Jun 17 19:48:21 PDT 2010


On 10-06-17 18:35, Sunil Mushran wrote:
> On 06/15/2010 09:08 PM, Wengang Wang wrote:
> >We should check dlm->dlm_state under dlm->spinlock though maybe in this case it
> >doesn't hurt.
> 
> NAK.
> 
> dlm->dlm_state is protected by dlm_domain_lock which is held at that time.
> 
>         /* NOTE: Next three are protected by dlm_domain_lock */
>         struct kref dlm_refs;
>         enum dlm_ctxt_state dlm_state;
>         unsigned int num_joins;

Yes, that's ture. thanks.



More information about the Ocfs2-devel mailing list