[Ocfs2-devel] [PATCH] ocfs2: Remove the deprecated inode_setattr.

Joel Becker Joel.Becker at oracle.com
Wed Jun 9 03:12:07 PDT 2010


On Wed, Jun 09, 2010 at 07:38:04PM +1000, Nick Piggin wrote:
> On Wed, Jun 09, 2010 at 05:29:37PM +0800, Tao Ma wrote:
> > We have a inode_newsize_ok check at the top of ocfs2_setattr when we
> > do the real work of truncate(it is far above, so the patch can't
> > have it. ;) ). So we don't need to worry about that actually.
> 
> OK, can you comment that or just open-code the truncate part of
> simple_setsize? It should be helpful for example with Christoph's
> truncate cleanup work.

	Just open-code it.  The void calls are much nicer than useless
return code boilerplate. 

Joel

-- 

 One look at the From:
 understanding has blossomed
 .procmailrc grows
	- Alexander Viro

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-devel mailing list