[Ocfs2-devel] [PATCH] ocfs2: Remove obscure error handling in direct_write.
Tao Ma
tao.ma at oracle.com
Wed Jun 9 01:48:59 PDT 2010
In ocfs2, actually we don't allow any direct write pass i_size,
see the function ocfs2_prepare_inode_for_write. So we don't
need the bogus simple_setsize.
Signed-off-by: Tao Ma <tao.ma at oracle.com>
---
fs/ocfs2/file.c | 11 -----------
1 files changed, 0 insertions(+), 11 deletions(-)
diff --git a/fs/ocfs2/file.c b/fs/ocfs2/file.c
index 06fd85c..4f782b0 100644
--- a/fs/ocfs2/file.c
+++ b/fs/ocfs2/file.c
@@ -2114,17 +2114,6 @@ relock:
written = generic_file_direct_write(iocb, iov, &nr_segs, *ppos,
ppos, count, ocount);
if (written < 0) {
- /*
- * direct write may have instantiated a few
- * blocks outside i_size. Trim these off again.
- * Don't need i_size_read because we hold i_mutex.
- *
- * XXX(hch): this looks buggy because ocfs2 did not
- * actually implement ->truncate. Take a look at
- * the new truncate sequence and update this accordingly
- */
- if (*ppos + count > inode->i_size)
- simple_setsize(inode, inode->i_size);
ret = written;
goto out_dio;
}
--
1.5.5
More information about the Ocfs2-devel
mailing list