[Ocfs2-devel] [PATCH V3 0/8] Cleancache: overview

[Dan Magenheimer]

> From: Nitin Gupta [mailto:ngupta at vflare.org]
> Sent: Friday, July 23, 2010 9:05 AM
> To: Dan Magenheimer
> Cc: Christoph Hellwig; akpm at linux-foundation.org; Chris Mason;
> viro at zeniv.linux.org.uk; adilger at sun.com; tytso at mit.edu;
> mfasheh at suse.com; Joel Becker; matthew at wil.cx; linux-
> btrfs at vger.kernel.org; linux-kernel at vger.kernel.org; linux-
> fsdevel at vger.kernel.org; linux-ext4 at vger.kernel.org; ocfs2-
> devel at oss.oracle.com; linux-mm at kvack.org; jeremy at goop.org;
> JBeulich at novell.com; Kurt Hackel; npiggin at suse.de; Dave Mccracken;
> riel at redhat.com; avi at redhat.com; Konrad Wilk
> Subject: Re: [PATCH V3 0/8] Cleancache: overview
> 
> On 07/23/2010 08:14 PM, Dan Magenheimer wrote:
> >> From: Christoph Hellwig [mailto:hch at infradead.org]
> 
> 
> >> Also making the ops vector global is just a bad idea.
> >> There is nothing making this sort of caching inherently global.
> >
> > I'm not sure I understand your point, but two very different
> > users of cleancache have been provided, and more will be
> > discussed at the MM summit next month.
> >
> > Do you have a suggestion on how to avoid a global ops
> > vector while still serving the needs of both existing
> > users?
> 
> Maybe introduce cleancache_register(struct cleancache_ops *ops)?
> This will allow making cleancache_ops non-global. No value add
> but maybe that's cleaner?

Oh, OK, that seems reasonable.

Dan