[Ocfs2-devel] [PATCH V2] Fix the nested PR lock calling issue

Jiaju Zhang jjzhang.linux at gmail.com
Thu Jul 22 06:16:12 PDT 2010


On Thu, Jul 22, 2010 at 6:11 PM, Wengang Wang <wen.gang.wang at oracle.com> wrote:
> ocfs2_get_acl_nolock() has the same functionality just with different
> arguments. And we can't replace it with the new _ocfs2_get_acl() for the
> call in ocfs2_init_acl().

I don't mean replace ocfs2_get_acl_nolock() with _ocfs2_get_acl().
What I'm just thinking is if we have the necessity of rename current
ocfs2_get_acl_nolock() with _ocfs2_get_acl(), and also rename current
_ocfs2_get_acl() in my patch with ocfs2_get_acl_nolock(). Anyway, it
is just a very minor change, I'm not sure if we should do it or not.

> So I am wondering if we really need the new _ocfs2_get_acl().

IMO, we may need _ocfs2_get_acl(). It will make the code looks clearer;)

Thanks,
Jiaju



More information about the Ocfs2-devel mailing list