[Ocfs2-devel] [PATCH v2] ocfs2: Don't duplicate page passes i_size during CoW.

[Joel Becker]

On Tue, Jul 13, 2010 at 01:13:06AM -0700, Joel Becker wrote:
> On Tue, Jul 13, 2010 at 11:22:32AM +0800, Tao Ma wrote:
> > +	/*
> > +	 * We only duplicate pages until we reach i_size.
> > +	 * So trim 'end' to the boundary of that page.
> > +	 */
> > +	if (end > i_size_read(context->inode))
> > +		end = ((i_size_read(context->inode) + PAGE_CACHE_SIZE - 1) >>
> > +			 PAGE_CACHE_SHIFT) << PAGE_CACHE_SHIFT;

	Why even worry about that?  We only need up to i_size.  If end
is safe and not page aligned, so is i_size.

Joel

-- 

Life's Little Instruction Book #451

	"Don't be afraid to say, 'I'm sorry.'"

Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127