[Ocfs2-devel] [PATCH] Cleancache: shim to Xen Transcendent Memory

Konrad Rzeszutek Wilk konrad.wilk at oracle.com
Mon Jul 12 08:05:22 PDT 2010


On Thu, Jul 08, 2010 at 09:42:08AM -0700, Dan Magenheimer wrote:
> Signed-off-by: Dan Magenheimer <dan.magenheimer at oracle.com>

One nitpick:
..
> +
> +int tmem_enabled;
> +
> +static int __init enable_tmem(char *s)
> +{
> +	tmem_enabled = 1;
> +	return 1;
> +}
> +
> +__setup("tmem", enable_tmem);

Perhaps 'tmem_setup' is more appropiate as it might be that this
function in the future would be only used to disable tmem, not actually
enable it?

Otherwise, it has been reviewed by me.



More information about the Ocfs2-devel mailing list