[Ocfs2-devel] [PATCH] ocfs2: make xattr extension work with new local alloc reservation.
Joel Becker
Joel.Becker at oracle.com
Thu Jul 8 11:36:23 PDT 2010
On Fri, Jun 18, 2010 at 11:02:50AM +0800, Tao Ma wrote:
> + goto restarted_transaction;
There's no need to confuse the issue with gotos here. Just make
it a loop, while (clusters_to_add). Make the vb->vb_access through
ocfs2_journal_dirty() parts a subfunction so that the loop is readable.
Have the subfunction return the number of clusters added, or -errno on
error. Then process the why in this function.
Joel
--
"Reader, suppose you were and idiot. And suppose you were a member of
Congress. But I repeat myself."
- Mark Twain
Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
More information about the Ocfs2-devel
mailing list