[Ocfs2-devel] [PATCH 2/2] ocfs2: No need to zero pages past i_size. i_size v2
Joel Becker
Joel.Becker at oracle.com
Tue Jul 6 11:39:46 PDT 2010
On Tue, Jul 06, 2010 at 12:09:19AM -0700, Joel Becker wrote:
> On Sun, Jul 04, 2010 at 11:13:01PM +0800, Tao Ma wrote:
> > > if (new) {
> > > wc->w_num_pages = ocfs2_pages_per_cluster(inode->i_sb);
> > > start = ocfs2_align_clusters_to_page_index(inode->i_sb, cpos);
> > >+ /* This is the index *past* the write */
> > >+ end_index = ((user_pos + user_len)>> PAGE_CACHE_SHIFT) + 1;
> > should it be
> > end_index = ((user_pos + user_len - 1) >> PAGE_CACHE_SHIFT) + 1?
>
> Maybe. Gotta think about it and test.
I think you're right. Since there are other changes too, I'm
going to add this in and test it.
Joel
--
"I'm drifting and drifting
Just like a ship out on the sea.
Cause I ain't got nobody, baby,
In this world to care for me."
Joel Becker
Consulting Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127
More information about the Ocfs2-devel
mailing list