[Ocfs2-devel] [PATCH 3/3] ocfs2:freeze-thaw: make it work

[Wengang Wang]

Sunil,

On 10-01-20 10:22, Sunil Mushran wrote:
> Wengang Wang wrote:
>> seems we need a noqueue version of the ocfs2_freeze_lock(). timeout it
>> after some retries.
>
> noqueue will not help. Launch a timer to fire off after 30 secs to do
> a cancel convert. If freeze succeeds before that, then cancel the timer.

I think the timer is not a very good idea. Canceling an ocfs2 cluster
lock is not complex though it needs lines of code changes. 
By your word, I felt you are meaning that the timer is a separated thing
from ocfs2_cluster_lock(). If so, we have to ensure the ocfs2_cluster_lock()
is really issued before the timer acts. Though here 30s is good that but are
we sure that it must be enough at any case? --I think we aren't.
Making sure cluster lock is issued before the timer acts, I guess we
need more code change and I think that is not worthy --it introduces bugs
and it's only for freeze/thaw, not a common demand.

So to avoid very long time waiting of a mount when cluster is frozen, I
want it make tries of no-queue cluster lock. And so does it when acquiring EX.

regards,
wengang.