[Ocfs2-devel] [PATCH 1/1] ocfs2: add extent block stealing for ocfs2 v4

Joel Becker Joel.Becker at oracle.com
Fri Jan 22 16:15:40 PST 2010


On Fri, Jan 22, 2010 at 04:13:22PM -0800, Joel Becker wrote:
> > +	atomic_set(&osb->s_num_meta_stolen, 0);
> >  	status = ocfs2_reserve_suballoc_bits(osb, (*ac),
> >  					     EXTENT_ALLOC_SYSTEM_INODE,
> > -					     slot, NULL, ALLOC_NEW_GROUP);
> > +					     (u32)osb->slot_num, NULL,
> 
> 	The int-vs-u32 casting is weird.  Note sure what to make of it.
> Why does ocfs2_reserve_suballoc_bits() take a u32 instead of an int?

	Oh, because the alloc context has a u32.  I blame someone.  But
let's leave it as you have it for now.

Joel

-- 

"Depend on the rabbit's foot if you will, but remember, it didn't
 help the rabbit."
	- R. E. Shay

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127



More information about the Ocfs2-devel mailing list