[Ocfs2-devel] [PATCH] ocfs2: fix __ocfs2_cluster_lock() dead lock

[Joel Becker]

On Wed, Jan 13, 2010 at 11:20:49AM +0800, Wengang Wang wrote:
> before update_holders, the lock could be DCed(since no BUSY flag set by
> here).
> 
> and even after update_holders, the lock could be DCed too.
> 
> so that we get ocfs2_cluster_lock()(with holders increased) returned sucessfully
> but actually we don't hold the dlm lock. --thus more than one node is
> considering that they have the (EX) lock.

	You make a good point.  I don't like the solution you propose,
though.  Another flag that's almost the same?  Eww!  There's got to be a
better way.

Joel

-- 

Life's Little Instruction Book #80

	"Slow dance"

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127