[Ocfs2-devel] [PATCH 1/2] Ocfs2: Move ocfs2 ioctl definitions from ocfs2_fs.h to new added ocfs2_ioctl.h.

[Joel Becker]

On Mon, Feb 08, 2010 at 05:21:58PM +0800, Tristan Ye wrote:
> diff --git a/fs/ocfs2/file.h b/fs/ocfs2/file.h
> index d66cf4f..eb891db 100644
> --- a/fs/ocfs2/file.h
> +++ b/fs/ocfs2/file.h
> @@ -26,6 +26,8 @@
>  #ifndef OCFS2_FILE_H
>  #define OCFS2_FILE_H
>  
> +#include "ocfs2_ioctl.h"
> +

	Why are you adding this header to file.h?  It makes no sense.

Joel

-- 

Life's Little Instruction Book #173

	"Be kinder than necessary."

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127