[Ocfs2-devel] [PATCH 2/3] Ocfs2: Change ocfs2_prepare_refcount_change_for_del() a bit to defer blocks reservation.

[Joel Becker]

On Thu, Jan 28, 2010 at 09:28:44AM +0800, tristan wrote:
> TaoMa wrote:
> > Hi Tristan,
> >    you'd better integrate this patch with patch 3/3. otherwise we 
> > can't build successfully if we apply this one and don't apply the next 
> > one(in some git bisect case).
> 
> Yes I see, here I just split the patches as small as possible to be 
> logically separate,  for the convenience of your reviewing:)

Tristan,
	Your instinct is good, but Tao is right, every commit has to
compile and work.  The next patches you work on, keep trying to break it
up into logical things, but have working code.  One of the best tricks
is doing the isomorphic changes (changes that don't actually affect the
behavior yet) first.  I use this trick a lot.  I can add an argument to
a function or change what is passed through without actually changing
the functionality.  Once I've used this methodology to restructure the
code, then I can change the behavior.
	For this particular change, I'm OK with it being one patch as I
stated in my other email.

Joel

-- 

"Vote early and vote often." 
        - Al Capone

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127