[Ocfs2-devel] [PATCH] ocfs2/dlm: Fix printing of lockname
Sunil Mushran
sunil.mushran at oracle.com
Fri Feb 5 17:14:32 PST 2010
Mark Fasheh wrote:
> On Fri, Feb 05, 2010 at 03:41:24PM -0800, Sunil Mushran wrote:
>
>> The debug call printing the name of the lock resource was chopping
>> off the last character. This patch fixes the problem.
>>
>> Signed-off-by: Sunil Mushran <sunil.mushran at oracle.com>
>> ---
>> fs/ocfs2/dlm/dlmdebug.c | 4 ++--
>> 1 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/fs/ocfs2/dlm/dlmdebug.c b/fs/ocfs2/dlm/dlmdebug.c
>> index f18afe9..7b4d1c1 100644
>> --- a/fs/ocfs2/dlm/dlmdebug.c
>> +++ b/fs/ocfs2/dlm/dlmdebug.c
>> @@ -97,12 +97,12 @@ void __dlm_print_one_lock_resource(struct dlm_lock_resource *res)
>> {
>> struct list_head *iter2;
>> struct dlm_lock *lock;
>> - char buf[DLM_LOCKID_NAME_MAX];
>> + char buf[DLM_LOCKID_NAME_MAX+1];
>>
>> assert_spin_locked(&res->spinlock);
>>
>> stringify_lockname(res->lockname.name, res->lockname.len,
>> - buf, sizeof(buf) - 1);
>> + buf, sizeof(buf));
>>
>
> I'm confused - isn't this part then increasing the value of the parameter
> by 2?
> --Mark
>
1 is for luck. ;) I'll resend the patch.
More information about the Ocfs2-devel
mailing list