[Ocfs2-devel] ocfs2: ei_cpos/phys confusion?
Tao Ma
tao.ma at oracle.com
Thu Feb 4 17:18:13 PST 2010
Hi Roel,
Roel Kluin wrote:
> in ocfs2_try_to_merge_extent_map(), vi fs/ocfs2/extent_map.c +185
>
> if (ins->ei_phys == (emi->ei_phys + emi->ei_clusters) &&
> ins->ei_cpos == (emi->ei_cpos + emi->ei_clusters) &&
> ins->ei_flags == emi->ei_flags) {
> emi->ei_clusters += ins->ei_clusters;
> return 1;
> } else if ((ins->ei_phys + ins->ei_clusters) == emi->ei_phys &&
> (ins->ei_cpos + ins->ei_clusters) == emi->ei_phys &&
> ----------------------------------------------------------------^^^^
> ins->ei_flags == emi->ei_flags) {
> emi->ei_phys = ins->ei_phys;
> emi->ei_cpos = ins->ei_cpos;
> emi->ei_clusters += ins->ei_clusters;
> return 1;
> }
>
> should that 2nd emi->ei_phys be emi->ei_cpos?
oh, yes, you are right. Do you want to provide a patch?
Regards,
Tao
>
> Roel
>
> _______________________________________________
> Ocfs2-devel mailing list
> Ocfs2-devel at oss.oracle.com
> http://oss.oracle.com/mailman/listinfo/ocfs2-devel
More information about the Ocfs2-devel
mailing list