[Ocfs2-devel] [PATCH 00/34] OCFS2: Add trace event and replace mlog(0).

[Christoph Hellwig]

On Fri, Dec 31, 2010 at 05:14:46AM -0800, Joel Becker wrote:
> On Fri, Dec 31, 2010 at 02:10:20PM +0100, Christoph Hellwig wrote:
> > I really don't like the way this is split into tons of patches, which
> > makes reviewing what's going on pretty hard.  In addition to the
> > preparatiory patch just one patch is more than enough, or if you really
> > want two: one to remove the old mlog code and one to add the trace
> > events.
> 
> 	I have to say, I would have found a single massive patch really
> painful to read.  The eye glazes over so many repetitive changes.  But
> I've now read it, and we can certainly push it upstream as one commit if
> you like.

It doesn't matter too much - in the end it's mostly you guys who have to
deal with it.