[Ocfs2-devel] [PATCH 1/3] Ocfs2: Using macro to set/clear *FILLED* flags in info handler.

[Joel Becker]

On Tue, Nov 16, 2010 at 06:13:40PM +0800, Tristan Ye wrote:
> @@ -139,7 +155,8 @@ int ocfs2_info_handle_blocksize(struct inode *inode,
>  		goto bail;
>  
>  	oib.ib_blocksize = inode->i_sb->s_blocksize;
> -	oib.ib_req.ir_flags |= OCFS2_INFO_FL_FILLED;
> +
> +	o2info_set_request_filled(oib);

	There's no need to add the extra line of whitespace for all of
these.  They're quite readable.

Joel

-- 

To spot the expert, pick the one who predicts the job will take the
longest and cost the most.

Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127