[Ocfs2-devel] [PATCH 1/1] Ocfs2: Teach 'coherency=full' O_DIRECT writes to correctly up_read i_alloc_sem.

[Joel Becker]

On Mon, Nov 22, 2010 at 11:20:56AM +0800, Tristan Ye wrote:
> >yes, it looks more natural and easy. So when you lock i_alloc_sem,
> >just call ocfs2_iocb_set_sem_locked, and when  you lock rw_lock,
> >just set the ocfs2_iocb_set_rw_locked. That's it. You don't neet
> >to think about some stuff like coherency or not.
> 
> Reasonable.
> 
> Joel,
> 
>    How do you think about it?

	I agree with Tao.  ocfs2_dio_end_io() doesn't care why the
locks are locked; it just needs to know which ones to release.

Joel
 

-- 

Life's Little Instruction Book #20

	"Be forgiving of yourself and others."

Joel Becker
Senior Development Manager
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127