[Ocfs2-devel] question about fs/ocfs2/dlm/dlmrecovery.c

Julia Lawall julia at diku.dk
Wed Aug 4 13:15:22 PDT 2010


The following code in the function dlm_process_recovery_data looks 
suspicious:

list_for_each_entry(lock, tmpq, list) {
	if (lock->ml.cookie != ml->cookie)
           	lock = NULL;
	else
                break;
}

list_for_each_entry moves around the list using its first argument, so it
doesn't seem safe to set that to NULL.  Maybe the "else" is not supposed to
be there?

julia



More information about the Ocfs2-devel mailing list