[Ocfs2-devel] [PATCH] ocfs2: avoid direct write if we fall back to buffered v3
Mark Fasheh
mfasheh at suse.com
Fri Apr 30 13:37:53 PDT 2010
On Mon, Apr 26, 2010 at 03:24:23PM -0700, Joel Becker wrote:
> On Sat, Apr 17, 2010 at 05:49:10PM +0800, Li Dongyang wrote:
> > when we fall back to buffered write from direct write, we call
> > __generic_file_aio_write but that will end up doing direct write
> > even we are only prepared to do buffered write because the file
> > has O_DIRECT flag set. This is a fix for
> > https://bugzilla.novell.com/show_bug.cgi?id=591039
> > revised with Joel's comments.
> >
> > Signed-off-by: Li Dongyang <lidongyang at novell.com>
>
> This looks good to me. I'd like Mark's ack before I push it to
> merge-window.
Looks good to me. Nice catch on the backing_dev_info bits.
Acked-by: Mark Fasheh <mfasheh at suse.com>
--Mark
--
Mark Fasheh
More information about the Ocfs2-devel
mailing list