[Ocfs2-devel] [PATCH 1/3] ocfs2: add OCFS2_INODE_SKIP_ORPHAN_DIR flag and honor it in the inode wipe code

Mark Fasheh mfasheh at suse.com
Fri Apr 23 10:32:47 PDT 2010


On Fri, Apr 23, 2010 at 10:30:28AM -0700, Mark Fasheh wrote:
> On Thu, Apr 22, 2010 at 04:11:19PM +0800, Li Dongyang wrote:
> > currently in the error path of ocfs2_symlink and ocfs2_mknod,
> > we just call iput with the inode we failed with, but the inode wipe code will
> > complain because we don't add the inode to orphan dir.
> > however, adding the inode to orphan dir requires additional transaction 
> > credits
> > which is too heavy for an error path, so we just use the

Actually, what's too heavy is the orphan dir locking. The transaction
credits aren't really a problem in this case.

Code's still good to go. You should update this description though.
	--Mark

--
Mark Fasheh



More information about the Ocfs2-devel mailing list