[Ocfs2-devel] [PATCH 1/2] Ocfs2: Add macro OCFS2_VOL_UUIDSTR_LEN in ocfs2_fs.h

[Joel Becker]

On Wed, Apr 21, 2010 at 11:32:37AM -0700, Sunil Mushran wrote:
> tristan wrote:
> > Sunil Mushran wrote:
> >> ok. So how about we remove this #define totally and have
> >> the ioctl interface return the binary uuid. The o2info tool
> >> can convert do the conversion.
> >
> > But... returning binary uuid from o2info was not that easy, ocfs2 
> > in-memory super_block osb only successfully initialized the osb->uuid, 
> > while did nothing to uuid_str, I remembered we've been discussing on 
> > that issue:
> >
> > http://oss.oracle.com/pipermail/ocfs2-devel/2009-November/005514.html
> >
> >
> > That patch was not adopted, and we're still using uuid_str in most 
> > places.
> 
> Ok. Thanks for reminding me.
> 
> It appears we already have OCFS2_TEXT_UUID_LEN in stack_user.c. That's a
> clean name. In the patch below, I have moved it to ocfs2.h so that we can
> use it elsewhere.
> 
> http://oss.oracle.com/~smushran/0001-ocfs2-Cleanup-uuid-strings.patch
> 
> I am waiting for Joel to comment. If he approves, then you can use the
> same #define in your ioctl.

	I'm glad you like the name, and I'm fine with you adding it to
ocfs2.h, but it should not be removing the define from stack_user.c.
Note that stack_user.c does not include ocfs2.h.

Joel

-- 

"Any man who is under 30, and is not a liberal, has not heart;
 and any man who is over 30, and is not a conservative, has no brains."
         - Sir Winston Churchill 

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127