[Ocfs2-devel] [PATCH] ocfs2: Update VFS inode's id info after reflink.

[Mark Fasheh]

On Wed, Apr 21, 2010 at 02:05:55PM +0800, Tao Ma wrote:
> In reflink we update the id info in the disk but forget to update
> the corresponding information in the VFS inode. So update them
> accordingly in case we want to preserve the attributes.
> 
> Reported-by: Jeff Liu <jeff.liu at oracle.com>
> Signed-off-by: Tao Ma <tao.ma at oracle.com>
> ---
>  fs/ocfs2/refcounttree.c |    3 +++
>  1 files changed, 3 insertions(+), 0 deletions(-)
> 
> diff --git a/fs/ocfs2/refcounttree.c b/fs/ocfs2/refcounttree.c
> index 8ae65c9..a8e8572 100644
> --- a/fs/ocfs2/refcounttree.c
> +++ b/fs/ocfs2/refcounttree.c
> @@ -4083,6 +4083,9 @@ static int ocfs2_complete_reflink(struct inode *s_inode,
>  	di->i_attr = s_di->i_attr;
>  
>  	if (preserve) {
> +		t_inode->i_uid = s_inode->i_uid;
> +		t_inode->i_gid = s_inode->i_gid;
> +		t_inode->i_mode = s_inode->i_mode;
>  		di->i_uid = s_di->i_uid;
>  		di->i_gid = s_di->i_gid;
>  		di->i_mode = s_di->i_mode;


Looks reasonable to me.

Acked-by: Mark Fasheh <mfasheh at suse.com>
	--Mark

--
Mark Fasheh