[Ocfs2-devel] [PATCH 13/15] ocfs2: ocfs2_group_bitmap_size has to handle old volume.

[Joel Becker]

On Fri, Apr 02, 2010 at 07:32:52AM +0800, Tao Ma wrote:
> I just went through all the callers of ocfs2_group_bitmap_size and
> it seems that it is called in 2 scenarios:
> 1. set bg_size.
> 2. check some situation in resize.
> 
> So how about change it to
> ocfs2_group_bitmap_size(struct super_block *sb, struct ocfs2_group_desc *gd)
> so if gd is NULL, we returns the old value, if not, just return bg_size.

	That makes no sense, because we're asking for "what it should
be", not "what it is".

> As for place of setting bg_size, we can set bg_bits first and then
> set bg_size to (bg_bits +7)/8.

	But when we grow a group, we'll set bg_size to 256, which blows
up tools.

Joel

-- 

You can use a screwdriver to screw in screws or to clean your ears,
however, the latter needs real skill, determination and a lack of fear
of injuring yourself.  It is much the same with JavaScript.
	- Chris Heilmann

Joel Becker
Principal Software Developer
Oracle
E-mail: joel.becker at oracle.com
Phone: (650) 506-8127